Network v2: add listDHCPNetworks for agents extension#1686
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Sep 2, 2019
Merged
Network v2: add listDHCPNetworks for agents extension#1686jtopjian merged 1 commit intogophercloud:masterfrom
jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
|
Build failed.
|
jtopjian
requested changes
Sep 2, 2019
Contributor
jtopjian
left a comment
There was a problem hiding this comment.
@notandy Thank you for submitting this.
In addition to the one review comment, please change occurrences of Dhcp to DHCP. Occurrences of dhcp should stay as dhcp.
Also, when implementing an API call, we need to see the actual Python code that implements the server-side action, not just the API docs. In this case, the relevant code is: https://github.com/openstack/neutron/blob/76754e06f56a7a9e4c23bef6a6e0e340e4110fa8/neutron/db/agentschedulers_db.py#L433-L443
Please let me know if you have any questions.
9f2bfe8 to
8a46546
Compare
this adds the listDHCPNetworks call for agents, that fetches a list of networks scheduled to a specific agent.
8a46546 to
bb4f6fb
Compare
|
Build failed.
|
Contributor
|
recheck |
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this add the listDHCPNetworks call for agents, enabling them
to fetch a list of networks scheduled to a specific agent.
Prior to starting a PR, please make sure you have read our
contributor tutorial.
Prior to a PR being reviewed, there needs to be a Github issue that the PR
addresses. Replace the brackets and text below with that issue number.
For #1389
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/neutron/blob/76754e06f56a7a9e4c23bef6a6e0e340e4110fa8/neutron/db/agentschedulers_db.py#L433-L443
https://docs.openstack.org/api-ref/network/v2/?expanded=list-networks-hosted-by-a-dhcp-agent-detail#list-networks-hosted-by-a-dhcp-agent