Skip to content

Containerinfra: Allow setting fixed_subnet when creating cluster#1676

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
lingxiankong:magnum-fixed-subnet
Aug 13, 2019
Merged

Containerinfra: Allow setting fixed_subnet when creating cluster#1676
jtopjian merged 1 commit intogophercloud:masterfrom
lingxiankong:magnum-fixed-subnet

Conversation

@lingxiankong
Copy link
Copy Markdown
Contributor

For #1673

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://github.com/openstack/magnum/blob/04fd0470ad3b35c4af5212eee82431b1be43d64c/magnum/api/controllers/v1/cluster.py#L180

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Aug 12, 2019

Build succeeded.

@lingxiankong
Copy link
Copy Markdown
Contributor Author

@jtopjian this PR is ready for review :-)

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 152a1e7 into gophercloud:master Aug 13, 2019
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 76.79% when pulling 9505ca3 on lingxiankong:magnum-fixed-subnet into 33168d2 on gophercloud:master.

@lingxiankong lingxiankong deleted the magnum-fixed-subnet branch August 14, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants