Compute: "policy", "rules" add servergroups Create#1636
Merged
ozerovandrei merged 3 commits intogophercloud:masterfrom Jul 9, 2019
Merged
Compute: "policy", "rules" add servergroups Create#1636ozerovandrei merged 3 commits intogophercloud:masterfrom
ozerovandrei merged 3 commits intogophercloud:masterfrom
Conversation
Add "policy" and "rules" extract methods to servergroups package. Those methods are available in 2.64 microversion.
Add "policy" and "rules" fields for servergroups Create call. Those fields are available in 2.64 microversion. Remove required attribute from the "policies" field. Add "omitempty" attribute to the Rules.MaxServerPerHost field.
Contributor
Author
|
recheck |
|
Build failed.
|
Contributor
Author
|
I will refactor servergroups tests to check that package with and without microversion additions. |
|
Build failed.
|
Use pointer to Rules in servergroups create options to prevent its addition to create options without microversion. Update servergroups package tests to test for cases with and without microversion 2.64.
8cdbf3a to
e02deb6
Compare
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "policy" and "rules" fields for servergroups Create call.
Those fields are available in 2.64 microversion.
Remove required attribute from the "policies" field.
Add "omitempty" attribute to the Rules.MaxServerPerHost field.
For #1600
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/nova/blob/stable/stein/nova/api/openstack/compute/server_groups.py#L186