Coverage decreased (-0.01%) to 76.834% when pulling 9ac3d14 on snigle:patch-1 into 1574321 on gophercloud:master.

Coverage increased (+0.003%) to 76.863% when pulling 2b33e88 on snigle:patch-1 into a26f5d9 on gophercloud:master.

Build succeeded.

• gophercloud-unittest : SUCCESS in 3m 59s
• gophercloud-acceptance-test : SUCCESS in 2h 26m 37s
• gophercloud-acceptance-test-ironic : SUCCESS in 25m 06s

@snigle Thank you for working on this.

Are you sure an interface is needed? Since all ErrDefaultNNN error types inherit from ErrUnexpectedResponseCode, then just having the GetStatusCode method will work without the need for an interface.

Also, would you be able to add some unit tests for this PR? Something like the following under a new file called gophercloud/testing/errors_test.go is a good start:

package testing

import (
  "testing"

  "github.com/gophercloud/gophercloud"
  th "github.com/gophercloud/gophercloud/testhelper"
)

func TestGetResponseCode(t *testing.T) {
  respErr := gophercloud.ErrUnexpectedResponseCode{
    URL:      "http://example.com",
    Method:   "GET",
    Expected: []int{200},
    Actual:   404,
    Body:     nil,
  }

  err404 := gophercloud.ErrDefault404{respErr}

  th.AssertEquals(t, err404.GetStatusCode(), 404)
}

@snigle Thank you for working on this.

Are you sure an interface is needed? Since all ErrDefaultNNN error types inherit from ErrUnexpectedResponseCode, then just having the GetStatusCode method will work without the need for an interface.

Also, would you be able to add some unit tests for this PR? Something like the following under a new file called gophercloud/testing/errors_test.go is a good start:

package testing

import (
  "testing"

  "github.com/gophercloud/gophercloud"
  th "github.com/gophercloud/gophercloud/testhelper"
)

func TestGetResponseCode(t *testing.T) {
  respErr := gophercloud.ErrUnexpectedResponseCode{
    URL:      "http://example.com",
    Method:   "GET",
    Expected: []int{200},
    Actual:   404,
    Body:     nil,
  }

  err404 := gophercloud.ErrDefault404{respErr}

  th.AssertEquals(t, err404.GetStatusCode(), 404)
}

I need the interface because gophercloud return error interface and not ErrDefault404 type. Added the test file thanks.

Build succeeded.

• gophercloud-unittest : SUCCESS in 3m 00s
• gophercloud-acceptance-test : SUCCESS in 1h 46m 07s
• gophercloud-acceptance-test-ironic : SUCCESS in 28m 59s

I need the interface because gophercloud return error interface and not ErrDefault404 type

Right, but you can cast any error to the common ErrUnexpectedResponseCode which would act the same as an interface. If this won't work for you, can you provide some example code that uses the interface so I can better understand the situation?

Superseded by #1820