Networking V2: add QoS rule type Get call#1625
Merged
ozerovandrei merged 1 commit intogophercloud:masterfrom Jun 13, 2019
Merged
Networking V2: add QoS rule type Get call#1625ozerovandrei merged 1 commit intogophercloud:masterfrom
ozerovandrei merged 1 commit intogophercloud:masterfrom
Conversation
Implement GetRuleType function with unit test.
Update QoS rule types documentation.
Update QoS rule types acceptance test.
Extend RuleType struct with additional fields. Unfortunately the
ParameterValues field is implemented as interface{} given it's dynamic
behavior (it can be map or slice in different situtations).
28 tasks
|
Build failed.
|
Contributor
Author
|
recheck |
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement GetRuleType function with unit test.
Update QoS rule types documentation.
Update QoS rule types acceptance test.
Extend RuleType struct with additional fields. Unfortunately the
ParameterValues field is implemented as interface{} given it's dynamic
behavior (it can be map or slice in different situtations).
For #1027
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/neutron-lib/blob/stable/stein/neutron_lib/api/definitions/qos_rule_type_details.py
https://github.com/openstack/neutron/blob/stable/stein/neutron/services/qos/drivers/manager.py#L88
https://github.com/openstack/neutron/blob/stable/stein/neutron/services/qos/qos_plugin.py#L369