Compute v2: Scheduler Hints Fix#1620
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Jun 12, 2019
Merged
Conversation
The "query" part of the scheduler_hints has never been correct. Instead of sending a nested JSON structure, the Nova API actually expects a marshalled JSON string which it will then decode.
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "query" part of the scheduler_hints has never been correct. Instead
of sending a nested JSON structure, the Nova API actually expects a
marshalled JSON string which it will then decode.
Normally we would probably just change
Queryto a typestringand make the application do the marshaling, but since this extension already has a lot of validation included, I opted to do the marshaling here.For #1619