Networking V2: add QoS policies acceptance tests#1603
Merged
ozerovandrei merged 4 commits intogophercloud:masterfrom Jun 10, 2019
Merged
Networking V2: add QoS policies acceptance tests#1603ozerovandrei merged 4 commits intogophercloud:masterfrom
ozerovandrei merged 4 commits intogophercloud:masterfrom
Conversation
Implement QoS policy update call.
Implement QoS policy delete method.
|
Build succeeded.
|
Contributor
Author
|
Looks like openlabtesting is down, it's better to recheck this PR after some time. |
Add TestPoliciesCRUD acceptance test and CreateQoSPolicy, DeleteQoSPolicy helpers.
47297cd to
6ee9145
Compare
|
Build failed.
|
Use StatusOK for Update QoS policy call.
Contributor
Author
|
Can't really find it in Neutron's code but Update call should return http.StatusOK (200) instead of http.StatusAccepted (202). It works similar to other Neutron extensions but its code is very difficult 😞 |
|
Build succeeded.
|
This was referenced Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TestPoliciesCRUD acceptance test and CreateQoSPolicy,
DeleteQoSPolicy helpers.
For #1027