Diagnostics Compute Extension#1592
Merged
jtopjian merged 2 commits intogophercloud:masterfrom Jun 4, 2019
Merged
Conversation
1 similar comment
|
Build succeeded.
|
Contributor
This truly looks like a structure that we can't deterministically model. Thank you for the research here. This PR looks good to me. Was there any additional work you wanted to do or is this ready to be merged? |
Contributor
Author
|
Yeah, with the different virt platforms it's pretty gnarly stuff to work with. It's probably better to let the consumer who knows what they're using(microversion, too) struct it out if they need to. This is ok to merge from my end. For now, this is all the work my project needs/produced. If I do find an improvement or add more functionality I can open a PR later. Thanks for all your help btw! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1585
The call for diagnostics comes into the nova api[1], is sent over rpc to the compute manager[2], and finally ends up depending on the driver[3]. My env uses libvirt, which builds and returns a 'single-level' python dict[4]. The response is hard to map to a struct in this scenario because there are possible extra values for extra vnics and disks.
Future work needs to be done on adding diagnostics/microversions.go to provide extract methods for a better structured, 'multi-level' dict response that is available with nova microversion 2.48 or higher[1][5], but I don't feel comfortable working on that without having it available in my environment to fully test against.
[1] https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/server_diagnostics.py#L42-L47
[2] https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3681-L3683
[3] https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4930-L4935
[4] https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L9183-L9241
[5] https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/views/server_diagnostics.py