Skip to content

Baremetal API V1: Allocations#1528

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
stbenjam:allocations
Mar 30, 2019
Merged

Baremetal API V1: Allocations#1528
jtopjian merged 1 commit intogophercloud:masterfrom
stbenjam:allocations

Conversation

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 27, 2019

Build failed.

@stbenjam stbenjam marked this pull request as ready for review March 27, 2019 18:38
@stbenjam stbenjam changed the title [WIP] Baremetal API V1: Allocations Baremetal API V1: Allocations Mar 27, 2019
@stbenjam
Copy link
Copy Markdown
Contributor Author

This should be ready for a review, thanks.

@stbenjam
Copy link
Copy Markdown
Contributor Author

@dtantsur FYI

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 27, 2019

Coverage Status

Coverage increased (+0.05%) to 76.637% when pulling b1cbc1e on stbenjam:allocations into 33e54f4 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 27, 2019

Build failed.

Copy link
Copy Markdown
Contributor

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, thanks!

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stbenjam Looks good. Just one change needed to the acceptance test and two doc nits.

@stbenjam stbenjam force-pushed the allocations branch 2 times, most recently from 073ad0c to e9fe23c Compare March 29, 2019 15:40
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 29, 2019

Build succeeded.

@stbenjam
Copy link
Copy Markdown
Contributor Author

@jtopjian Updated, should be good to go

@jtopjian jtopjian merged commit 4d3066f into gophercloud:master Mar 30, 2019
@stbenjam stbenjam deleted the allocations branch March 30, 2019 19:01
@stbenjam
Copy link
Copy Markdown
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants