Skip to content

Baremetal API: noauth support#1449

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
stbenjam:noauth
Feb 15, 2019
Merged

Baremetal API: noauth support#1449
jtopjian merged 1 commit intogophercloud:masterfrom
stbenjam:noauth

Conversation

@stbenjam
Copy link
Copy Markdown
Contributor

@stbenjam stbenjam commented Feb 12, 2019

For #1429

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+3.8%) to 80.066% when pulling c522a8f on stbenjam:noauth into 98bc0d0 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 12, 2019

Build succeeded.

@jtopjian
Copy link
Copy Markdown
Contributor

@stbenjam This looks good to me. Is this ready for review?

If you can, please post a comment when ready for review/merge - otherwise it might be interpreted as a WIP.

@stbenjam
Copy link
Copy Markdown
Contributor Author

Sure thing, this is ready for review.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@jtopjian jtopjian merged commit 9e57e2f into gophercloud:master Feb 15, 2019
@stbenjam stbenjam deleted the noauth branch February 15, 2019 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants