Networking V2: add Agent Get request#1391
Merged
jtopjian merged 5 commits intogophercloud:masterfrom Jan 12, 2019
Merged
Conversation
Add "networking/v2/extensions/agents" package with List request. Provide unit test and documentation.
Contributor
Author
|
recheck |
|
Build succeeded.
|
Contributor
|
Both List and Get LGTM, except that |
Rename "AdminStateUP" into "AdminStateUp".
Add Get method for the "networking/v2/extensions/agents" package. Provide unit test and documentation.
Add TestAgentsRead for testing reading of real Networking V2 agents.
Rename "AdminStateUP" into "AdminStateUp" in TestGet() function.
d87838f to
664f33b
Compare
|
Build failed.
|
Contributor
Author
|
It failed on loadbalancers: |
Contributor
Author
|
recheck |
|
Build succeeded.
|
Contributor
Author
|
@jtopjian both PRs are ready. |
jtopjian
approved these changes
Jan 12, 2019
Contributor
jtopjian
left a comment
There was a problem hiding this comment.
LGTM - thank you for working on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Get method for the "networking/v2/extensions/agents" package.
Provide unit test and documentation.
Add TestAgentsRead for testing reading of real Networking V2 agents.
For #1389
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
Code reference(API)
Code reference(DB)