Add DefaultPoolID update support#1313
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Dec 7, 2018
Merged
Conversation
Contributor
|
@kayrus Thank you for submitting this. Per the PR template, can you please review the contributor tutorial? Notably, a corresponding Issue needs opened for this. Additionally, you're referencing the Load Balancer API documentation, so perhaps this change should go under here instead? Or maybe both? The tutorial will detail how to confirm these things. Please let me know if you have any questions. |
|
Build succeeded.
|
6ff5cd6 to
5cc442b
Compare
|
Build succeeded.
|
5cc442b to
6030893
Compare
6030893 to
a417135
Compare
|
Build succeeded.
|
jtopjian
reviewed
Dec 7, 2018
Contributor
jtopjian
left a comment
There was a problem hiding this comment.
This looks good to me. Let me know if this is ready to be merged.
Contributor
Author
|
It is ready. |
jtopjian
approved these changes
Dec 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Openstack v2 API supports
default_pool_idupdatehttps://developer.openstack.org/api-ref/load-balancer/v2/index.html?expanded=update-a-listener-detail#update-a-listener