-
Notifications
You must be signed in to change notification settings - Fork 583
Please consider fixing more bad APIs in v2.0 #2902
Description
I saw that you put out a v2.0.0 beta, and the breaking changes are very tame. Since this is a unique opportunity, I wonder how many thoughts have been spent on improving the core APIs. Specifically, I have two requests:
-
Please consider removing all the
Err4xxerinterfaces andErrDefault4xxstructs without replacement, and just returningErrUnexpectedResponseCodeinstead. Or at the very least, these types should be documented much better to explain what their purpose is. As far as I can tell, all they do is ruin good error messages unless you know how to get rid of them. -
The
context.Contextsupport added in the previous release is pretty much worthless since all the structured API methods do not takectxarguments. This is the best possible moment to fix that, and add actxargument to every method that wrapsProviderClient.RequestorServiceClient.Request. The variants of those methods withoutctxarguments should be removed.
This just off the top of my head, there's probably more. Please consider using this opportunity if at all possible.