Skip to content

manila share-types: add IDFromName convenience function#1662

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
gman0:manila-sharetype-idfromname
Aug 1, 2019
Merged

manila share-types: add IDFromName convenience function#1662
jtopjian merged 1 commit intogophercloud:masterfrom
gman0:manila-sharetype-idfromname

Conversation

@gman0
Copy link
Copy Markdown
Contributor

@gman0 gman0 commented Jul 31, 2019

For #1663

This PR adds IDFromName convenience function for Manila share types.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 31, 2019

Coverage Status

Coverage increased (+1.7%) to 78.476% when pulling 5558622 on gman0:manila-sharetype-idfromname into 8014bd3 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jul 31, 2019

Build failed.

@gman0
Copy link
Copy Markdown
Contributor Author

gman0 commented Jul 31, 2019

PTAL @jtopjian

@jtopjian
Copy link
Copy Markdown
Contributor

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Aug 1, 2019

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you

@jtopjian jtopjian merged commit 7f00c45 into gophercloud:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants