Skip to content

Allow modification of the container secret refs#1659

Merged
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:barbican-secret-ref
Jul 30, 2019
Merged

Allow modification of the container secret refs#1659
jtopjian merged 2 commits intogophercloud:masterfrom
kayrus:barbican-secret-ref

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Jul 29, 2019

Resolves #1658

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 29, 2019

Coverage Status

Coverage increased (+3.5%) to 80.362% when pulling 21aeea9 on kayrus:barbican-secret-ref into 73bf16e on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jul 29, 2019

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Jul 29, 2019

@jtopjian ready for review

return s.Consumers, err
}

type secretRefResult struct {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this being used?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this was a copy-paste. Will remove it.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kayrus In general this looks good. I understand reusing SecretRef in results.go - that should be okay to do.

Just one question about how secretRefResult is being used.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jul 30, 2019

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 4e334c7 into gophercloud:master Jul 30, 2019
@kayrus kayrus deleted the barbican-secret-ref branch March 23, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Key Manager V1: Allow modification of the container secret references

3 participants