[Neutron][Network] updated_at/created_at fields#1657
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Jul 30, 2019
Merged
[Neutron][Network] updated_at/created_at fields#1657jtopjian merged 1 commit intogophercloud:masterfrom
jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
|
Build failed.
|
for: gophercloud#1655 * time.Time object * mapped to existing json fields General API reference:https://docs.openstack.org/api-ref/network/v2/?expanded=show-network-details-detail#show-network-details that fields defined in standard_attr.py , that means that it should be applied to all neutron-resources though decorator: https://github.com/openstack/neutron/blob/041203f1bb1a9cb814ab58c6088d0229cfe9d9bb/neutron/db/standard_attr.py#L181 https://github.com/openstack/neutron/blob/041203f1bb1a9cb814ab58c6088d0229cfe9d9bb/neutron/db/models_v2.py#L253
1 similar comment
|
Build failed.
|
Contributor
Author
|
@jtopjian ready for review. Faced with acceptance test failures, again seems it does not correlate with my changes, can anybody take a look and advice? |
Contributor
|
recheck |
|
Build failed.
|
Contributor
|
recheck |
|
Build succeeded.
|
Contributor
Author
|
@jtopjian seems everything is ok? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for: #1655
General API reference:https://docs.openstack.org/api-ref/network/v2/?expanded=show-network-details-detail#show-network-details
that fields defined in standard_attr.py , that means that it should be applied to all neutron-resources though decorator:
https://github.com/openstack/neutron/blob/041203f1bb1a9cb814ab58c6088d0229cfe9d9bb/neutron/db/standard_attr.py#L181
https://github.com/openstack/neutron/blob/041203f1bb1a9cb814ab58c6088d0229cfe9d9bb/neutron/db/models_v2.py#L253