baremetal: add WaitForProvisionState and expand tests

dtantsur · dtantsur · commit f646332da084 · 2024-03-15T12:10:25.000+01:00
diff --git a/internal/acceptance/openstack/baremetal/v1/nodes_test.go b/internal/acceptance/openstack/baremetal/v1/nodes_test.go
@@ -21,7 +21,7 @@ func TestNodesCreateDestroy(t *testing.T) {
 	th.AssertNoErr(t, err)
 	client.Microversion = "1.38"
 
-	node, err := CreateNode(t, client)
+	node, err := CreateFakeNode(t, client)
 	th.AssertNoErr(t, err)
 	defer DeleteNode(t, client, node)
 
@@ -42,8 +42,17 @@ func TestNodesCreateDestroy(t *testing.T) {
 		return false, nil
 	})
 	th.AssertNoErr(t, err)
-
 	th.AssertEquals(t, found, true)
+
+	th.AssertEquals(t, node.ProvisionState, string(nodes.Enroll))
+
+	err = nodes.ChangeProvisionState(context.TODO(), client, node.UUID, nodes.ProvisionStateOpts{
+		Target: nodes.TargetManage,
+	}).ExtractErr()
+	th.AssertNoErr(t, err)
+
+	err = nodes.WaitForProvisionState(context.TODO(), client, node.UUID, nodes.Manageable, 5)
+	th.AssertNoErr(t, err)
 }
 
 func TestNodesFields(t *testing.T) {
diff --git a/openstack/baremetal/v1/nodes/util.go b/openstack/baremetal/v1/nodes/util.go
@@ -0,0 +1,25 @@
+package nodes
+
+import (
+	"context"
+
+	"github.com/gophercloud/gophercloud/v2"
+)
+
+// WaitForProvisionState will continually poll a node until it successfully
+// transitions to a specified state. It will do this for at most the number
+// of seconds specified.
+func WaitForProvisionState(ctx context.Context, c *gophercloud.ServiceClient, id string, state ProvisionState, secs int) error {
+	return gophercloud.WaitFor(secs, func() (bool, error) {
+		current, err := Get(ctx, c, id).Extract()
+		if err != nil {
+			return false, err
+		}
+
+		if current.ProvisionState == string(state) {
+			return true, nil
+		}
+
+		return false, nil
+	})
+}
