Compute V2: implement Add method for Tags

ozerovandrei · ozerovandrei · commit eb62adba2de7 · 2019-09-13T15:46:28.000+03:00
Implement compute/v2/extensions/tags.Add.

Update package documentation.
diff --git a/openstack/compute/v2/extensions/tags/doc.go b/openstack/compute/v2/extensions/tags/doc.go
@@ -33,11 +33,20 @@ Example to Replace all Tags on a server
 
     client.Microversion = "2.62"
 
-    newTags, err := tags.ReplaceAll(client, serverID, tags. tags.ReplaceAllOpts{Tags: []string{"foo", "bar"}}).Extract()
+    newTags, err := tags.ReplaceAll(client, serverID, tags.ReplaceAllOpts{Tags: []string{"foo", "bar"}}).Extract()
     if err != nil {
         log.Fatal(err)
     }
 
     fmt.Printf("New tags: %v\n", newTags)
+
+Example to Add a new Tag on a server
+
+    client.Microversion = "2.62"
+
+    err := tags.Add(client, serverID, "foo").ExtractErr()
+    if err != nil {
+        log.Fatal(err)
+    }
 */
 package tags
diff --git a/openstack/compute/v2/extensions/tags/requests.go b/openstack/compute/v2/extensions/tags/requests.go
@@ -35,7 +35,7 @@ func (opts ReplaceAllOpts) ToTagsReplaceAllMap() (map[string]interface{}, error)
 	return gophercloud.BuildRequestBody(opts, "")
 }
 
-// ReplaceAll replaces all tags on a server.
+// ReplaceAll replaces all Tags on a server.
 func ReplaceAll(client *gophercloud.ServiceClient, serverID string, opts ReplaceAllOptsBuilder) (r ReplaceAllResult) {
 	b, err := opts.ToTagsReplaceAllMap()
 	url := replaceAllURL(client, serverID)
@@ -48,3 +48,12 @@ func ReplaceAll(client *gophercloud.ServiceClient, serverID string, opts Replace
 	})
 	return
 }
+
+// Add adds a new Tag on a server.
+func Add(client *gophercloud.ServiceClient, serverID, tag string) (r AddResult) {
+	url := addURL(client, serverID, tag)
+	_, r.Err = client.Put(url, nil, nil, &gophercloud.RequestOpts{
+		OkCodes: []int{201, 204},
+	})
+	return
+}
diff --git a/openstack/compute/v2/extensions/tags/results.go b/openstack/compute/v2/extensions/tags/results.go
@@ -40,3 +40,8 @@ func (r CheckResult) Extract() (bool, error) {
 type ReplaceAllResult struct {
 	commonResult
 }
+
+// AddResult is the result from the Add operation.
+type AddResult struct {
+	gophercloud.ErrResult
+}
diff --git a/openstack/compute/v2/extensions/tags/testing/requests_test.go b/openstack/compute/v2/extensions/tags/testing/requests_test.go
@@ -87,3 +87,35 @@ func TestReplaceAll(t *testing.T) {
 	th.AssertNoErr(t, err)
 	th.AssertDeepEquals(t, expected, actual)
 }
+
+func TestAddCreated(t *testing.T) {
+	th.SetupHTTP()
+	defer th.TeardownHTTP()
+
+	th.Mux.HandleFunc("/servers/uuid1/tags/foo", func(w http.ResponseWriter, r *http.Request) {
+		th.TestMethod(t, r, "PUT")
+		th.TestHeader(t, r, "X-Auth-Token", client.TokenID)
+
+		w.Header().Add("Content-Type", "application/json")
+		w.WriteHeader(http.StatusCreated)
+	})
+
+	err := tags.Add(client.ServiceClient(), "uuid1", "foo").ExtractErr()
+	th.AssertNoErr(t, err)
+}
+
+func TestAddExists(t *testing.T) {
+	th.SetupHTTP()
+	defer th.TeardownHTTP()
+
+	th.Mux.HandleFunc("/servers/uuid1/tags/foo", func(w http.ResponseWriter, r *http.Request) {
+		th.TestMethod(t, r, "PUT")
+		th.TestHeader(t, r, "X-Auth-Token", client.TokenID)
+
+		w.Header().Add("Content-Type", "application/json")
+		w.WriteHeader(http.StatusNoContent)
+	})
+
+	err := tags.Add(client.ServiceClient(), "uuid1", "foo").ExtractErr()
+	th.AssertNoErr(t, err)
+}
diff --git a/openstack/compute/v2/extensions/tags/urls.go b/openstack/compute/v2/extensions/tags/urls.go
@@ -26,3 +26,7 @@ func checkURL(c *gophercloud.ServiceClient, serverID, tag string) string {
 func replaceAllURL(c *gophercloud.ServiceClient, serverID string) string {
 	return rootURL(c, serverID)
 }
+
+func addURL(c *gophercloud.ServiceClient, serverID, tag string) string {
+	return resourceURL(c, serverID, tag)
+}

Original file line number	Diff line number	Diff line change
`@@ -40,3 +40,8 @@ func (r CheckResult) Extract() (bool, error) {`
`40`	`40`	`type ReplaceAllResult struct {`
`41`	`41`	`commonResult`
`42`	`42`	`}`
	`43`	`+`
	`44`	`+// AddResult is the result from the Add operation.`
	`45`	`+type AddResult struct {`
	`46`	`+ gophercloud.ErrResult`
	`47`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -26,3 +26,7 @@ func checkURL(c *gophercloud.ServiceClient, serverID, tag string) string {`
`26`	`26`	`func replaceAllURL(c *gophercloud.ServiceClient, serverID string) string {`
`27`	`27`	`return rootURL(c, serverID)`
`28`	`28`	`}`
	`29`	`+`
	`30`	`+func addURL(c *gophercloud.ServiceClient, serverID, tag string) string {`
	`31`	`+ return resourceURL(c, serverID, tag)`
	`32`	`+}`