Skip to content

Commit bc87166

Browse files
jtopjianjtopjian
authored
Acc Tests: Skipping some tests on older OpenStack releases (#2001)
* Acc Tests: Skipping some tests on older OpenStack releases * BlockStorage v3: Adding 202 response to Attachemnt create * Acc Tests: Skipping tests for newer releases
1 parent 2dc49a3 commit bc87166

10 files changed

Lines changed: 58 additions & 2 deletions

File tree

‎acceptance/openstack/blockstorage/v3/volumeattachments_test.go‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ import (
1212
)
1313

1414
func TestVolumeAttachments(t *testing.T) {
15+
clients.SkipRelease(t, "stable/mitaka")
16+
clients.SkipRelease(t, "stable/newton")
17+
clients.SkipRelease(t, "stable/ocata")
18+
1519
blockClient, err := clients.NewBlockStorageV3Client()
1620
th.AssertNoErr(t, err)
1721

‎acceptance/openstack/compute/v2/quotaset_test.go‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ func TestQuotasetGet(t *testing.T) {
2424
clients.SkipRelease(t, "stable/queens")
2525
clients.SkipRelease(t, "stable/rocky")
2626
clients.SkipRelease(t, "stable/stein")
27+
clients.SkipRelease(t, "stable/train")
28+
clients.SkipRelease(t, "stable/ussuri")
2729

2830
client, err := clients.NewComputeV2Client()
2931
th.AssertNoErr(t, err)
@@ -117,6 +119,8 @@ func TestQuotasetUpdateDelete(t *testing.T) {
117119
clients.SkipRelease(t, "stable/queens")
118120
clients.SkipRelease(t, "stable/rocky")
119121
clients.SkipRelease(t, "stable/stein")
122+
clients.SkipRelease(t, "stable/train")
123+
clients.SkipRelease(t, "stable/ussuri")
120124

121125
clients.RequireAdmin(t)
122126

‎acceptance/openstack/compute/v2/services_test.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ func TestServicesListWithOpts(t *testing.T) {
6565
}
6666

6767
func TestServicesUpdate(t *testing.T) {
68+
clients.SkipRelease(t, "stable/ocata")
6869
clients.RequireAdmin(t)
6970

7071
client, err := clients.NewComputeV2Client()

‎acceptance/openstack/identity/v3/oauth1_test.go‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ import (
1515
)
1616

1717
func TestOAuth1CRUD(t *testing.T) {
18+
clients.SkipRelease(t, "stable/mitaka")
19+
clients.SkipRelease(t, "stable/newton")
20+
clients.SkipRelease(t, "stable/ocata")
21+
1822
client, err := clients.NewIdentityV3Client()
1923
th.AssertNoErr(t, err)
2024

‎acceptance/openstack/identity/v3/projects_test.go‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,9 @@ func TestProjectsNested(t *testing.T) {
196196
}
197197

198198
func TestProjectsTags(t *testing.T) {
199+
clients.SkipRelease(t, "stable/mitaka")
200+
clients.SkipRelease(t, "stable/newton")
201+
clients.SkipRelease(t, "stable/ocata")
199202
clients.RequireAdmin(t)
200203

201204
client, err := clients.NewIdentityV3Client()

‎acceptance/openstack/identity/v3/roles_test.go‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ func TestRolesFilterList(t *testing.T) {
112112
clients.RequireAdmin(t)
113113

114114
// For some reason this is not longer working.
115-
// It might be a temporary issue.
116115
clients.SkipRelease(t, "master")
117116
clients.SkipRelease(t, "stable/mitaka")
118117
clients.SkipRelease(t, "stable/newton")
@@ -121,6 +120,8 @@ func TestRolesFilterList(t *testing.T) {
121120
clients.SkipRelease(t, "stable/queens")
122121
clients.SkipRelease(t, "stable/rocky")
123122
clients.SkipRelease(t, "stable/stein")
123+
clients.SkipRelease(t, "stable/train")
124+
clients.SkipRelease(t, "stable/ussuri")
124125

125126
client, err := clients.NewIdentityV3Client()
126127
th.AssertNoErr(t, err)

‎acceptance/openstack/identity/v3/trusts_test.go‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@ import (
1717
)
1818

1919
func TestTrustCRUD(t *testing.T) {
20+
clients.SkipRelease(t, "stable/mitaka")
21+
clients.SkipRelease(t, "stable/newton")
22+
clients.SkipRelease(t, "stable/ocata")
23+
clients.SkipRelease(t, "stable/pike")
24+
clients.SkipRelease(t, "stable/queens")
2025
clients.RequireAdmin(t)
2126

2227
client, err := clients.NewIdentityV3Client()

‎acceptance/openstack/placement/v1/resourceproviders_test.go‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ func TestResourceProviderList(t *testing.T) {
2727
}
2828

2929
func TestResourceProviderCreate(t *testing.T) {
30+
clients.SkipRelease(t, "stable/mitaka")
31+
clients.SkipRelease(t, "stable/newton")
32+
clients.SkipRelease(t, "stable/ocata")
33+
clients.SkipRelease(t, "stable/pike")
34+
clients.SkipRelease(t, "stable/queens")
3035
clients.RequireAdmin(t)
3136

3237
client, err := clients.NewPlacementV1Client()
@@ -47,6 +52,13 @@ func TestResourceProviderCreate(t *testing.T) {
4752
}
4853

4954
func TestResourceProviderUsages(t *testing.T) {
55+
clients.SkipRelease(t, "stable/mitaka")
56+
clients.SkipRelease(t, "stable/newton")
57+
clients.SkipRelease(t, "stable/ocata")
58+
clients.SkipRelease(t, "stable/pike")
59+
clients.SkipRelease(t, "stable/queens")
60+
clients.RequireAdmin(t)
61+
5062
clients.RequireAdmin(t)
5163

5264
client, err := clients.NewPlacementV1Client()
@@ -72,6 +84,11 @@ func TestResourceProviderUsages(t *testing.T) {
7284
}
7385

7486
func TestResourceProviderInventories(t *testing.T) {
87+
clients.SkipRelease(t, "stable/mitaka")
88+
clients.SkipRelease(t, "stable/newton")
89+
clients.SkipRelease(t, "stable/ocata")
90+
clients.SkipRelease(t, "stable/pike")
91+
clients.SkipRelease(t, "stable/queens")
7592
clients.RequireAdmin(t)
7693

7794
client, err := clients.NewPlacementV1Client()
@@ -97,6 +114,11 @@ func TestResourceProviderInventories(t *testing.T) {
97114
}
98115

99116
func TestResourceProviderTraits(t *testing.T) {
117+
clients.SkipRelease(t, "stable/mitaka")
118+
clients.SkipRelease(t, "stable/newton")
119+
clients.SkipRelease(t, "stable/ocata")
120+
clients.SkipRelease(t, "stable/pike")
121+
clients.SkipRelease(t, "stable/queens")
100122
clients.RequireAdmin(t)
101123

102124
client, err := clients.NewPlacementV1Client()

‎acceptance/openstack/sharedfilesystems/v2/messages/messages_test.go‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ const requestID = "req-6f52cd8b-25a1-42cf-b497-7babf70f55f4"
1212
const minimumManilaMessagesMicroVersion = "2.37"
1313

1414
func TestMessageList(t *testing.T) {
15+
clients.SkipRelease(t, "stable/mitaka")
16+
clients.SkipRelease(t, "stable/newton")
17+
clients.SkipRelease(t, "stable/ocata")
18+
1519
client, err := clients.NewSharedFileSystemV2Client()
1620
if err != nil {
1721
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -36,6 +40,10 @@ func TestMessageList(t *testing.T) {
3640
// The test creates 2 messages and verifies that only the one(s) with
3741
// a particular name are being listed
3842
func TestMessageListFiltering(t *testing.T) {
43+
clients.SkipRelease(t, "stable/mitaka")
44+
clients.SkipRelease(t, "stable/newton")
45+
clients.SkipRelease(t, "stable/ocata")
46+
3947
client, err := clients.NewSharedFileSystemV2Client()
4048
if err != nil {
4149
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -67,6 +75,10 @@ func TestMessageListFiltering(t *testing.T) {
6775
// Create a message and update the name and description. Get the ity
6876
// service and verify that the name and description have been updated
6977
func TestMessageDelete(t *testing.T) {
78+
clients.SkipRelease(t, "stable/mitaka")
79+
clients.SkipRelease(t, "stable/newton")
80+
clients.SkipRelease(t, "stable/ocata")
81+
7082
client, err := clients.NewSharedFileSystemV2Client()
7183
if err != nil {
7284
t.Fatalf("Unable to create shared file system client: %v", err)

‎openstack/blockstorage/v3/attachments/requests.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func Create(client *gophercloud.ServiceClient, opts CreateOptsBuilder) (r Create
4747
return
4848
}
4949
resp, err := client.Post(createURL(client), b, &r.Body, &gophercloud.RequestOpts{
50-
OkCodes: []int{200},
50+
OkCodes: []int{200, 202},
5151
})
5252
_, r.Header, r.Err = gophercloud.ParseResponse(resp, err)
5353
return

0 commit comments

Comments
 (0)