Skip to content

Commit ada7a8b

Browse files
committed
TestPortsbindingCRUD: Fix order of arguments in equal assertions
The correct order is `expected`, `actual`. Having this right helps debugging since the values are printed in a log message.
1 parent 9379f86 commit ada7a8b

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

internal/acceptance/openstack/networking/v2/extensions/portsbinding/portsbinding_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ func TestPortsbindingCRUD(t *testing.T) {
4040
defer networking.DeletePort(t, client, port.ID)
4141

4242
tools.PrintResource(t, port)
43-
th.AssertEquals(t, port.HostID, hostID)
44-
th.AssertEquals(t, port.VNICType, "normal")
45-
th.AssertDeepEquals(t, port.Profile, profile)
43+
th.AssertEquals(t, hostID, port.HostID)
44+
th.AssertEquals(t, "normal", port.VNICType)
45+
th.AssertDeepEquals(t, profile, port.Profile)
4646

4747
// Update port
4848
newPortName := ""
@@ -72,9 +72,9 @@ func TestPortsbindingCRUD(t *testing.T) {
7272
th.AssertNoErr(t, err)
7373

7474
tools.PrintResource(t, newPort)
75-
th.AssertEquals(t, newPort.Description, newPortName)
76-
th.AssertEquals(t, newPort.Description, newPortDescription)
77-
th.AssertEquals(t, newPort.HostID, newHostID)
78-
th.AssertEquals(t, newPort.VNICType, "normal")
79-
th.AssertDeepEquals(t, newPort.Profile, newProfile)
75+
th.AssertEquals(t, newPortName, newPort.Description)
76+
th.AssertEquals(t, newPortDescription, newPort.Description)
77+
th.AssertEquals(t, newHostID, newPort.HostID)
78+
th.AssertEquals(t, "normal", newPort.VNICType)
79+
th.AssertDeepEquals(t, newProfile, newPort.Profile)
8080
}

0 commit comments

Comments
 (0)