Skip to content

Commit 8b22827

Browse files
mandremandre
authored
Merge pull request #2361 from EmilienM/manila_ci
Adding CI job for testing sharedfilesystems (Manila)
2 parents a76c350 + 99f7526 commit 8b22827

4 files changed

Lines changed: 73 additions & 56 deletions

File tree

‎.github/workflows/functional-sharedfilesystems.yaml‎

Lines changed: 73 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
1+
name: functional-sharedfilesystems
2+
on:
3+
pull_request:
4+
paths:
5+
- '**sharedfilesystems**'
6+
schedule:
7+
- cron: '0 0 * * *'
8+
jobs:
9+
functional-sharedfilesystems:
10+
strategy:
11+
fail-fast: false
12+
matrix:
13+
name: ["master"]
14+
openstack_version: ["master"]
15+
ubuntu_version: ["20.04"]
16+
include:
17+
- name: "xena"
18+
openstack_version: "stable/xena"
19+
ubuntu_version: "20.04"
20+
- name: "wallaby"
21+
openstack_version: "stable/wallaby"
22+
ubuntu_version: "20.04"
23+
- name: "victoria"
24+
openstack_version: "stable/victoria"
25+
ubuntu_version: "20.04"
26+
- name: "ussuri"
27+
openstack_version: "stable/ussuri"
28+
ubuntu_version: "18.04"
29+
- name: "train"
30+
openstack_version: "stable/train"
31+
ubuntu_version: "18.04"
32+
runs-on: ubuntu-${{ matrix.ubuntu_version }}
33+
name: Deploy OpenStack ${{ matrix.name }} with Manila and run sharedfilesystems acceptance tests
34+
steps:
35+
- name: Checkout Gophercloud
36+
uses: actions/checkout@v2
37+
- name: Deploy devstack
38+
uses: EmilienM/devstack-action@v0.6
39+
with:
40+
branch: ${{ matrix.openstack_version }}
41+
conf_overrides: |
42+
enable_plugin manila https://opendev.org/openstack/manila ${{ matrix.openstack_version }}
43+
# LVM Backend config options
44+
MANILA_SERVICE_IMAGE_ENABLED=False
45+
SHARE_DRIVER=manila.share.drivers.lvm.LVMShareDriver
46+
MANILA_ENABLED_BACKENDS=chicago,denver
47+
MANILA_BACKEND1_CONFIG_GROUP_NAME=chicago
48+
MANILA_BACKEND2_CONFIG_GROUP_NAME=denver
49+
MANILA_SHARE_BACKEND1_NAME=CHICAGO
50+
MANILA_SHARE_BACKEND2_NAME=DENVER
51+
MANILA_OPTGROUP_chicago_driver_handles_share_servers=False
52+
MANILA_OPTGROUP_denver_driver_handles_share_servers=False
53+
SHARE_BACKING_FILE_SIZE=32000M
54+
MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS='snapshot_support=True create_share_from_snapshot_support=True revert_to_snapshot_support=True mount_snapshot_support=True'
55+
MANILA_CONFIGURE_DEFAULT_TYPES=True
56+
- name: Checkout go
57+
uses: actions/setup-go@v2
58+
with:
59+
go-version: '^1.15'
60+
- name: Run Gophercloud acceptance tests
61+
run: ./script/acceptancetest
62+
env:
63+
DEVSTACK_PATH: ${{ github.workspace }}/devstack
64+
ACCEPTANCE_TESTS_FILTER: "^.*sharedfilesystems.*$"
65+
- name: Generate logs on failure
66+
run: ./script/collectlogs
67+
if: failure()
68+
- name: Upload logs artifacts on failure
69+
if: failure()
70+
uses: actions/upload-artifact@v2
71+
with:
72+
name: functional-sharedfilesystems-${{ matrix.name }}
73+
path: /tmp/devstack-logs/*

‎acceptance/openstack/sharedfilesystems/v2/messages/messages_test.go‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@ const requestID = "req-6f52cd8b-25a1-42cf-b497-7babf70f55f4"
1212
const minimumManilaMessagesMicroVersion = "2.37"
1313

1414
func TestMessageList(t *testing.T) {
15-
clients.SkipRelease(t, "stable/mitaka")
16-
clients.SkipRelease(t, "stable/newton")
17-
clients.SkipRelease(t, "stable/ocata")
18-
1915
client, err := clients.NewSharedFileSystemV2Client()
2016
if err != nil {
2117
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -40,10 +36,6 @@ func TestMessageList(t *testing.T) {
4036
// The test creates 2 messages and verifies that only the one(s) with
4137
// a particular name are being listed
4238
func TestMessageListFiltering(t *testing.T) {
43-
clients.SkipRelease(t, "stable/mitaka")
44-
clients.SkipRelease(t, "stable/newton")
45-
clients.SkipRelease(t, "stable/ocata")
46-
4739
client, err := clients.NewSharedFileSystemV2Client()
4840
if err != nil {
4941
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -75,10 +67,6 @@ func TestMessageListFiltering(t *testing.T) {
7567
// Create a message and update the name and description. Get the ity
7668
// service and verify that the name and description have been updated
7769
func TestMessageDelete(t *testing.T) {
78-
clients.SkipRelease(t, "stable/mitaka")
79-
clients.SkipRelease(t, "stable/newton")
80-
clients.SkipRelease(t, "stable/ocata")
81-
8270
client, err := clients.NewSharedFileSystemV2Client()
8371
if err != nil {
8472
t.Fatalf("Unable to create shared file system client: %v", err)

‎acceptance/openstack/sharedfilesystems/v2/shares_test.go‎

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ import (
1313
)
1414

1515
func TestShareCreate(t *testing.T) {
16-
clients.SkipRelease(t, "stable/mitaka")
17-
clients.SkipRelease(t, "stable/newton")
18-
1916
client, err := clients.NewSharedFileSystemV2Client()
2017
if err != nil {
2118
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -36,9 +33,6 @@ func TestShareCreate(t *testing.T) {
3633
}
3734

3835
func TestShareExportLocations(t *testing.T) {
39-
clients.SkipRelease(t, "stable/mitaka")
40-
clients.SkipRelease(t, "stable/newton")
41-
4236
client, err := clients.NewSharedFileSystemV2Client()
4337
if err != nil {
4438
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -73,9 +67,6 @@ func TestShareExportLocations(t *testing.T) {
7367
}
7468

7569
func TestShareUpdate(t *testing.T) {
76-
clients.SkipRelease(t, "stable/mitaka")
77-
clients.SkipRelease(t, "stable/newton")
78-
7970
client, err := clients.NewSharedFileSystemV2Client()
8071
if err != nil {
8172
t.Fatalf("Unable to create shared file system client: %v", err)
@@ -125,9 +116,6 @@ func TestShareUpdate(t *testing.T) {
125116
}
126117

127118
func TestShareListDetail(t *testing.T) {
128-
clients.SkipRelease(t, "stable/mitaka")
129-
clients.SkipRelease(t, "stable/newton")
130-
131119
client, err := clients.NewSharedFileSystemV2Client()
132120
if err != nil {
133121
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -151,9 +139,6 @@ func TestShareListDetail(t *testing.T) {
151139
}
152140

153141
func TestGrantAndRevokeAccess(t *testing.T) {
154-
clients.SkipRelease(t, "stable/mitaka")
155-
clients.SkipRelease(t, "stable/newton")
156-
157142
client, err := clients.NewSharedFileSystemV2Client()
158143
if err != nil {
159144
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -180,9 +165,6 @@ func TestGrantAndRevokeAccess(t *testing.T) {
180165
}
181166

182167
func TestListAccessRights(t *testing.T) {
183-
clients.SkipRelease(t, "stable/mitaka")
184-
clients.SkipRelease(t, "stable/newton")
185-
186168
client, err := clients.NewSharedFileSystemV2Client()
187169
if err != nil {
188170
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -218,9 +200,6 @@ func TestListAccessRights(t *testing.T) {
218200
}
219201

220202
func TestExtendAndShrink(t *testing.T) {
221-
clients.SkipRelease(t, "stable/mitaka")
222-
clients.SkipRelease(t, "stable/newton")
223-
224203
client, err := clients.NewSharedFileSystemV2Client()
225204
if err != nil {
226205
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -264,9 +243,6 @@ func TestExtendAndShrink(t *testing.T) {
264243
}
265244

266245
func TestShareMetadata(t *testing.T) {
267-
clients.SkipRelease(t, "stable/mitaka")
268-
clients.SkipRelease(t, "stable/newton")
269-
270246
client, err := clients.NewSharedFileSystemV2Client()
271247
if err != nil {
272248
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -326,9 +302,6 @@ func TestShareMetadata(t *testing.T) {
326302
}
327303

328304
func TestRevert(t *testing.T) {
329-
clients.SkipRelease(t, "stable/mitaka")
330-
clients.SkipRelease(t, "stable/newton")
331-
332305
client, err := clients.NewSharedFileSystemV2Client()
333306
if err != nil {
334307
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -381,9 +354,6 @@ func TestRevert(t *testing.T) {
381354
}
382355

383356
func TestResetStatus(t *testing.T) {
384-
clients.SkipRelease(t, "stable/mitaka")
385-
clients.SkipRelease(t, "stable/newton")
386-
387357
client, err := clients.NewSharedFileSystemV2Client()
388358
if err != nil {
389359
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -420,9 +390,6 @@ func TestResetStatus(t *testing.T) {
420390
}
421391

422392
func TestForceDelete(t *testing.T) {
423-
clients.SkipRelease(t, "stable/mitaka")
424-
clients.SkipRelease(t, "stable/newton")
425-
426393
client, err := clients.NewSharedFileSystemV2Client()
427394
if err != nil {
428395
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -455,8 +422,6 @@ func TestForceDelete(t *testing.T) {
455422
}
456423

457424
func TestUnmanage(t *testing.T) {
458-
clients.SkipRelease(t, "stable/mitaka")
459-
clients.SkipRelease(t, "stable/newton")
460425
clients.RequireAdmin(t)
461426

462427
client, err := clients.NewSharedFileSystemV2Client()

‎acceptance/openstack/sharedfilesystems/v2/snapshots_test.go‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ import (
1313
)
1414

1515
func TestSnapshotCreate(t *testing.T) {
16-
clients.SkipRelease(t, "stable/mitaka")
17-
clients.SkipRelease(t, "stable/newton")
18-
1916
client, err := clients.NewSharedFileSystemV2Client()
2017
if err != nil {
2118
t.Fatalf("Unable to create a shared file system client: %v", err)
@@ -44,9 +41,6 @@ func TestSnapshotCreate(t *testing.T) {
4441
}
4542

4643
func TestSnapshotUpdate(t *testing.T) {
47-
clients.SkipRelease(t, "stable/mitaka")
48-
clients.SkipRelease(t, "stable/newton")
49-
5044
client, err := clients.NewSharedFileSystemV2Client()
5145
if err != nil {
5246
t.Fatalf("Unable to create shared file system client: %v", err)
@@ -97,9 +91,6 @@ func TestSnapshotUpdate(t *testing.T) {
9791
}
9892

9993
func TestSnapshotListDetail(t *testing.T) {
100-
clients.SkipRelease(t, "stable/mitaka")
101-
clients.SkipRelease(t, "stable/newton")
102-
10394
client, err := clients.NewSharedFileSystemV2Client()
10495
if err != nil {
10596
t.Fatalf("Unable to create a shared file system client: %v", err)

0 commit comments

Comments
 (0)