Merge pull request #2560 from danfai/fix-creating-fully-populated-lb

mandre · web-flow · commit 38ee8b7eab72 · 2023-08-02T07:23:59.000+02:00
loadbalancer: Use CreateMemberOpts instead of BatchUpdateMemberOpts in PoolCreateOpts
diff --git a/acceptance/openstack/loadbalancer/v2/loadbalancer.go b/acceptance/openstack/loadbalancer/v2/loadbalancer.go
@@ -195,12 +195,12 @@ func CreateLoadBalancerFullyPopulated(t *testing.T, client *gophercloud.ServiceC
 				Description: poolDescription,
 				Protocol:    pools.ProtocolHTTP,
 				LBMethod:    pools.LBMethodLeastConnections,
-				Members: []pools.BatchUpdateMemberOpts{{
-					Name:         &memberName,
+				Members: []pools.CreateMemberOpts{{
+					Name:         memberName,
 					ProtocolPort: memberPort,
 					Weight:       &memberWeight,
 					Address:      "1.2.3.4",
-					SubnetID:     &subnetID,
+					SubnetID:     subnetID,
 				}},
 				Monitor: &monitors.CreateOpts{
 					Delay:          10,
diff --git a/openstack/loadbalancer/v2/loadbalancers/testing/requests_test.go b/openstack/loadbalancer/v2/loadbalancers/testing/requests_test.go
@@ -110,7 +110,7 @@ func TestCreateFullyPopulatedLoadbalancer(t *testing.T) {
 				LBMethod: pools.LBMethodRoundRobin,
 				Protocol: "HTTP",
 				Name:     "Example pool",
-				Members: []pools.BatchUpdateMemberOpts{{
+				Members: []pools.CreateMemberOpts{{
 					Address:      "192.0.2.51",
 					ProtocolPort: 80,
 				}, {
diff --git a/openstack/loadbalancer/v2/pools/requests.go b/openstack/loadbalancer/v2/pools/requests.go
@@ -123,12 +123,12 @@ type CreateOpts struct {
 	// or false (DOWN).
 	AdminStateUp *bool `json:"admin_state_up,omitempty"`
 
-	// Members is a slice of BatchUpdateMemberOpts which allows a set of
+	// Members is a slice of CreateMemberOpts which allows a set of
 	// members to be created at the same time the pool is created.
 	//
 	// This is only possible to use when creating a fully populated
 	// Loadbalancer.
-	Members []BatchUpdateMemberOpts `json:"members,omitempty"`
+	Members []CreateMemberOpts `json:"members,omitempty"`
 
 	// Monitor is an instance of monitors.CreateOpts which allows a monitor
 	// to be created at the same time the pool is created.
