Merge pull request #505 from jtopjian/computev2-flavor-acctest

jtopjian · web-flow · commit 31ccc1afefa5 · 2017-08-26T09:22:49.000-06:00
Compute v2: Flavor acceptance test
diff --git a/acceptance/openstack/compute/v2/compute.go b/acceptance/openstack/compute/v2/compute.go
@@ -23,6 +23,7 @@ import (
 	"github.com/gophercloud/gophercloud/openstack/compute/v2/extensions/servergroups"
 	"github.com/gophercloud/gophercloud/openstack/compute/v2/extensions/tenantnetworks"
 	"github.com/gophercloud/gophercloud/openstack/compute/v2/extensions/volumeattach"
+	"github.com/gophercloud/gophercloud/openstack/compute/v2/flavors"
 	"github.com/gophercloud/gophercloud/openstack/compute/v2/servers"
 
 	"golang.org/x/crypto/ssh"
@@ -136,6 +137,29 @@ func CreateDefaultRule(t *testing.T, client *gophercloud.ServiceClient) (dsr.Def
 	return *defaultRule, nil
 }
 
+// CreateFlavor will create a flavor with a random name.
+// An error will be returned if the flavor could not be created.
+func CreateFlavor(t *testing.T, client *gophercloud.ServiceClient) (*flavors.Flavor, error) {
+	flavorName := tools.RandomString("flavor_", 5)
+	t.Logf("Attempting to create flavor %s", flavorName)
+
+	createOpts := flavors.CreateOpts{
+		Name:  flavorName,
+		RAM:   1,
+		VCPUs: 1,
+		Disk:  gophercloud.IntToPointer(1),
+	}
+
+	flavor, err := flavors.Create(client, createOpts).Extract()
+	if err != nil {
+		return nil, err
+	}
+
+	t.Logf("Successfully created flavor %s", flavor.ID)
+
+	return flavor, nil
+}
+
 // CreateFloatingIP will allocate a floating IP.
 // An error will be returend if one was unable to be allocated.
 func CreateFloatingIP(t *testing.T, client *gophercloud.ServiceClient) (*floatingips.FloatingIP, error) {
@@ -531,6 +555,17 @@ func DeleteDefaultRule(t *testing.T, client *gophercloud.ServiceClient, defaultR
 	t.Logf("Deleted default rule: %s", defaultRule.ID)
 }
 
+// DeleteFlavor will delete a flavor. A fatal error will occur if the flavor
+// could not be deleted. This works best when using it as a deferred function.
+func DeleteFlavor(t *testing.T, client *gophercloud.ServiceClient, flavor *flavors.Flavor) {
+	err := flavors.Delete(client, flavor.ID).ExtractErr()
+	if err != nil {
+		t.Fatalf("Unable to delete flavor %s", flavor.ID)
+	}
+
+	t.Logf("Deleted flavor: %s", flavor.ID)
+}
+
 // DeleteFloatingIP will de-allocate a floating IP. A fatal error will occur if
 // the floating IP failed to de-allocate. This works best when using it as a
 // deferred function.
diff --git a/acceptance/openstack/compute/v2/flavors_test.go b/acceptance/openstack/compute/v2/flavors_test.go
@@ -72,3 +72,18 @@ func TestFlavorsGet(t *testing.T) {
 
 	tools.PrintResource(t, flavor)
 }
+
+func TestFlavorCreateDelete(t *testing.T) {
+	client, err := clients.NewComputeV2Client()
+	if err != nil {
+		t.Fatalf("Unable to create a compute client: %v", err)
+	}
+
+	flavor, err := CreateFlavor(t, client)
+	if err != nil {
+		t.Fatalf("Unable to create flavor: %v", err)
+	}
+	defer DeleteFlavor(t, client, flavor)
+
+	tools.PrintResource(t, flavor)
+}
