Geneve SerializeTo improvements#9
Merged
mosajjal merged 2 commits intogopacket:masterfrom Oct 6, 2022
mejedi:geneve_serialize_improvements
Merged
Geneve SerializeTo improvements#9mosajjal merged 2 commits intogopacket:masterfrom mejedi:geneve_serialize_improvements
mosajjal merged 2 commits intogopacket:masterfrom
mejedi:geneve_serialize_improvements
Conversation
We run the risk of panicing on buffer overflow if option lengths in the packet are blindly trusted in serialization. In line with the precedent set elsewhere (e.g. IPv4, TCP), compute the necessary buffer size based on the actual options size. Fill lengths fields from user-provided values, even if those are wrong. Signed-off-by: Nick Zavaritsky <mejedi@gmail.com>
Signed-off-by: Nick Zavaritsky <mejedi@gmail.com>
Contributor
|
hey thanks for this. can you provide a description of what this does and what current problem you've seen with the current code. |
Contributor
Author
This adds support for FixLengths option in SerializeTo. Please see commit messages for details. |
Contributor
|
thanks. is this ready to merge? happy to merge if so :) |
Contributor
Author
|
This is ready. Thank you for reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.