Skip to content

parse TLS client hello packet#8

Merged
mosajjal merged 1 commit intogopacket:masterfrom
zhangbo1882:tls
Sep 28, 2022
Merged

parse TLS client hello packet#8
mosajjal merged 1 commit intogopacket:masterfrom
zhangbo1882:tls

Conversation

@zhangbo1882
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: bozhang <bozhang@ebay.com>
@zhangbo1882
Copy link
Copy Markdown
Contributor Author

Does anyone approve running workflows?

@mosajjal
Copy link
Copy Markdown
Contributor

mosajjal commented Sep 4, 2022

hey there. yep I can approve the tests. I got a question around the order of TLS extensions inside the hello packet. does your code cater for that?

@zhangbo1882
Copy link
Copy Markdown
Contributor Author

zhangbo1882 commented Sep 5, 2022 via email

@mosajjal
Copy link
Copy Markdown
Contributor

good idea to add this to this PR

@zhangbo1882
Copy link
Copy Markdown
Contributor Author

@mosajjal it seems that this PR has included the feature that PR provides.

@mosajjal mosajjal merged commit 43ab360 into gopacket:master Sep 28, 2022
@mosajjal
Copy link
Copy Markdown
Contributor

cool. Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants