Add support for bundled SCTP chunks#72
Merged
mosajjal merged 1 commit intogopacket:masterfrom Nov 9, 2024
Merged
Conversation
Solution already proposed at google/gopacket#835
mosajjal
approved these changes
Nov 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
I came across a problem while working with SCTP packets. According to the specification of SCTP there a packet might contain multiple chunks bundled together if the packet size allows it.
Sadly,
gopacketdoes not yet support this while parsing or serializing. This is not a new issue and has already been discussed (google/gopacket#347) and a working solution has been proposed (google/gopacket#835)Is there any change on getting this approved for a next release? And please let me know if there is anything I can do to speed up the process.