Fix Dot11InformationElement processing#64
Merged
mosajjal merged 1 commit intogopacket:masterfrom Nov 9, 2024
Merged
Conversation
Move offset check within check for vendor extension (221) as this appears to be a bug as the else statement never uses offset+4. Previously this would cause small elements to fail processing as it wasn't limited to only vendor elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move offset check within check for vendor extension (221) as this appears to be a bug as the else statement never uses . Previously this would cause small elements to fail processing as it wasn't limited to only vendor elements.
Small Dot11InformationElements that were failing included:
and
The
len(data) < offset+4is a valid check, but only for a vendor specific element such as:As other elements don't contain this OUI+Type.