Skip to content

feat: add read support for Name Resolution Block#38

Merged
mosajjal merged 3 commits intogopacket:masterfrom
frafos:name-resolution-blocks
Apr 21, 2024
Merged

feat: add read support for Name Resolution Block#38
mosajjal merged 3 commits intogopacket:masterfrom
frafos:name-resolution-blocks

Conversation

@raphaelcoeffic
Copy link
Copy Markdown
Contributor

No description provided.

@mosajjal mosajjal self-assigned this Dec 2, 2023
@mosajjal
Copy link
Copy Markdown
Contributor

mosajjal commented Feb 6, 2024

Hi,

thanks for your patience with this PR. I'm keen for us to have nrb_record_eui48 and nrb_record_eui64 supported as well. also, netip.Addr is preferable to net.IP for the record if possible.

@raphaelcoeffic
Copy link
Copy Markdown
Contributor Author

I'm keen for us to have nrb_record_eui48 and nrb_record_eui64 supported as well. also, netip.Addr is preferable to net.IP for the record if possible.

Thx for taking a look. I'll add this once I circle back to that. We delayed integrating that feature internally.

@raphaelcoeffic
Copy link
Copy Markdown
Contributor Author

@mosajjal I added read support for nrb_record_eui48 and nrb_record_eui64, but could not really test for lack of usable PCAPNG file. It does not seem to be supported with the LUA tests either. Would you have some hint for me please how this could be tested?

@mosajjal
Copy link
Copy Markdown
Contributor

mosajjal commented Apr 6, 2024

yeah I'm struggling to find good samples as well. but I think so far it looks good to me. we can test it as a PR with different files and see how it works and what would be the best next step.

@raphaelcoeffic
Copy link
Copy Markdown
Contributor Author

yeah I'm struggling to find good samples as well. but I think so far it looks good to me. we can test it as a PR with different files and see how it works and what would be the best next step.

Thx, let me know if you need anything.

@mosajjal mosajjal merged commit f0b345d into gopacket:master Apr 21, 2024
@raphaelcoeffic raphaelcoeffic deleted the name-resolution-blocks branch July 6, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants