Merged
Conversation
Contributor
|
looks good. can you please add a DHCP discover packet with no option to the test suite as well. |
For calculating the DHCPv4 length by the "Len" method there is always a byte added for the end option. But the END option is only set when there are any options at all. This results in a missing END option in case there are no options present. This commit moves the encoding of the END option so it is always set unconditionally.
e7c3cfb to
29bbec8
Compare
Contributor
Author
|
Thanks for the review. I added a test that fails without the fix: And works with the fix: |
Contributor
|
excellent. I'm happy with it if you are. |
1 similar comment
Contributor
|
excellent. I'm happy with it if you are. |
Contributor
Author
|
Nice, I'm happy with it. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For calculating the DHCPv4 length by the "Len" method there is always a byte added for the end option. But the END option is only set when there are any options at all. This results in a missing END option in case there are no options present.
This commit moves the encoding of the END option so it is always set unconditionally.