Relax length check on pflog packets#20
Merged
mosajjal merged 1 commit intogopacket:masterfrom Jul 11, 2023
Merged
Conversation
OpenBSD pflog adds some fields which aren't present in FreeBSD, as a result the packet's padding is different.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenBSD pflog adds some fields which aren't present in FreeBSD, as a result the packet's padding is different.
This change was made a long time ago in openbsd/src@72d1fa5
I've brought over the change from google/gopacket#1066, thanks @dennisoelkers for that. This doesn't add parsing for the additional fields (although this commit is enough to unblock the error, you can get the additional fields out of
.Contentsmanually, but it might make sense to add them to the layer)