Fixes for Geneve option flags/length field#17
Merged
mosajjal merged 2 commits intogopacket:masterfrom Jun 27, 2023
Merged
Conversation
added 2 commits
June 1, 2023 13:45
The option header length is 5 bits, not 4, so fix the bit shift for decoding flags, and fix the mask for decoding the length. This also adds a unit test for decoding a max length option (124 byte payload).
OR-assigning the flag bits into the byte offset for the Geneve option header flags/length field produced corrupt packets because the buffer returned by PrependBytes is not guaranteed to be zeroed out. Since this is the first time that offset is touched, just assign instead.
Contributor
|
hey mate. is this a draft or ready to be merged? |
Contributor
Author
G'day 😉 - ready to be merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two bugs in the Geneve implementation: