Skip to content

Fix integer size for linux-386 builds#16

Merged
mosajjal merged 1 commit intogopacket:masterfrom
cholland1989:linux-386-int-size
May 4, 2023
Merged

Fix integer size for linux-386 builds#16
mosajjal merged 1 commit intogopacket:masterfrom
cholland1989:linux-386-int-size

Conversation

@cholland1989
Copy link
Copy Markdown
Contributor

@cholland1989 cholland1989 commented May 4, 2023

We recently switched to this version of gopacket and started seeing the following errors when building for linux-386 targets:

Error: /home/runner/go/pkg/mod/github.com/gopacket/gopacket@v1.1.0/pcapgo/capture.go:112:29: cannot use tstamp.Sec (variable of type int32) as int64 value in argument to time.Unix
Error: /home/runner/go/pkg/mod/github.com/gopacket/gopacket@v1.1.0/pcapgo/capture.go:112:41: cannot use tstamp.Nsec (variable of type int32) as int64 value in argument to time.Unix
Error: /home/runner/go/pkg/mod/github.com/gopacket/gopacket@v1.1.0/pcapgo/capture.go:115:29: cannot use tstamp.Sec (variable of type int32) as int64 value in argument to time.Unix

This PR fixes the issue by explicitly casting these values to int64 before use in the time.Unix call.

mosajjal
mosajjal approved these changes May 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mosajjal mosajjal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. was this making 386 to fail? interesting find!

@mosajjal mosajjal merged commit 44b8a6a into gopacket:master May 4, 2023
@wolveix wolveix mentioned this pull request Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mosajjal mosajjal mosajjal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cholland1989 @mosajjal