fix: resolve eqField validation for pointer types in the validator#310
Merged
inhere merged 1 commit intogookit:masterfrom Sep 3, 2025
Merged
fix: resolve eqField validation for pointer types in the validator#310inhere merged 1 commit intogookit:masterfrom
inhere merged 1 commit intogookit:masterfrom
Conversation
Pull Request Test Coverage Report for Build 17421918091Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #272
This PR resolves an issue where the eqField validation rule did not properly handle pointer types in structs. Previously, when comparing fields like
FieldA *stringandFieldB *stringusingeqField:FieldA, the validator would fail to correctly assess equality if both fields were pointers.With this fix,
eqFieldnow correctly dereferences pointer values and compares their actual contents, ensuring accurate validation for pointer fields.