Skip to content

chore(ci): fix typo in restrict presubmit samples ITs to only snapshot #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 2 commits into from
Oct 26, 2020
Merged

chore(ci): fix typo in restrict presubmit samples ITs to only snapshot #826

gcf-merge-on-green merged 2 commits into from
Oct 26, 2020

Conversation

@stephaniewang526
Copy link
Contributor

@stephaniewang526 stephaniewang526 commented Oct 23, 2020 •
edited
Loading

Fixes below error in Java repos when #804 was merged:

github/java-bigquerystorage/.kokoro/build.sh: line 81: pushd: {SAMPLES_DIR}: No such file or directory

Thanks @kolea2 for spotting this in Fusion build logs.

cc @chingor13

@stephaniewang526 stephaniewang526 requested a review from a team as a code owner October 23, 2020 16:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2020
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit f68649c into googleapis:master Oct 26, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 kolea2 approved these changes

@chingor13 chingor13 Awaiting requested review from chingor13

+1 more reviewer

@SurferJeffAtGoogle SurferJeffAtGoogle SurferJeffAtGoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephaniewang526 @SurferJeffAtGoogle @kolea2