Skip to content

fix: allow local and external deps to be specified #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
busunkim96 merged 1 commit into from
Apr 7, 2020
Merged

fix: allow local and external deps to be specified #469

busunkim96 merged 1 commit into from
Apr 7, 2020

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Apr 7, 2020 •
edited
Loading

Modify noxfile.py to allow local and external dependencies for
system tests to be specified.

templated_files = gcp.CommonTemplates().py_library(
    unit_cov_level=97, 
    cov_level=99, 
    system_test_local_dependencies=["test_utils"],
    system_test_external_dependencies=["psutil"]
)

@busunkim96
fix: allow local and external deps to be specified
92f6201 
Modify noxfile.py to allow local and external dependencies for
system tests to be specified.
@busunkim96 busunkim96 requested a review from plamut April 7, 2020 00:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2020
@busunkim96 busunkim96 mentioned this pull request Apr 7, 2020
Merged
plamut
plamut approved these changes Apr 7, 2020
View reviewed changes
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busunkim96 busunkim96 merged commit 188f1b1 into master Apr 7, 2020
@fhinkel fhinkel deleted the fix-py-noxfile branch October 21, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@plamut plamut plamut approved these changes

@SurferJeffAtGoogle SurferJeffAtGoogle SurferJeffAtGoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@busunkim96 @plamut @SurferJeffAtGoogle @googlebot