feat(java_template): add support for enable-integration-tests and enable-samples maven profiles #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@chingor13 please review. |
elharo
reviewed
Dec 18, 2019
| </project> | ||
| ``` | ||
|
|
||
| 2. [Activate](#profile-activation) the profile. |
Contributor
There was a problem hiding this comment.
you don't need to activate now. That's done at runtime. This step can be deleted.
Contributor
Author
There was a problem hiding this comment.
Activation can be done via settings.xml so that it's not needed on the command line, this leaves the option for folks to pick which activation they want to use.
| respected by IntelliJ IDEA) and is recommended if you are going to be | ||
| contributing samples to several projects. | ||
|
|
||
| #### IntelliJ IDEA |
Contributor
There was a problem hiding this comment.
This IntelliJ section isn't needed given the above.
Contributor
Author
There was a problem hiding this comment.
If the developer picks to add it to their settings.xml true, but if they don't this helps them do it (maybe for a single project instead of several).
SurferJeffAtGoogle
suggested changes
Dec 18, 2019
chingor13
approved these changes
Jan 2, 2020
Contributor
Author
|
@chingor13 I've rebased to clean up any conflicts. This should be ready to merge now with the passing checks. |
chingor13
approved these changes
Jan 2, 2020
…ble-samples maven profiles In `com.google.cloud:google-cloud-shared-config:0.3.1` integration tests are skipped by default to reduce friction from contributors that do not have a service account or access to GCP services. This change updates our templates to provide instructions on how to enable integration tests as well as passing the necessary arguments to our builds. With the incorporation of Code Samples into the project repos we need new configuration and control in maven to allow building on jdk7 and excluding samples from release deploy builds. This change adds new build configs for samples and a new target to build.sh to build samples.
SurferJeffAtGoogle
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
com.google.cloud:google-cloud-shared-config:0.3.1integration testsare skipped by default to reduce friction from contributors that do not
have a service account or access to GCP services. This change updates
our templates to provide instructions on how to enable integration tests
as well as passing the necessary arguments to our builds.
With the incorporation of Code Samples into the project repos we need
new configuration and control in maven to allow building on jdk7 and
excluding samples from release deploy builds. This change adds new build
configs for samples and a new target to build.sh to build samples.