chore(python): use python 3.10 for docs build#1989
Merged
Conversation
vchudnov-g
approved these changes
Jul 8, 2024
vchudnov-g
approved these changes
Jul 8, 2024
|
|
||
| # Use python 3.9 by default | ||
| ###################### Use python 3.9 by default | ||
|
|
ohmayr
approved these changes
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue
E: Package 'python3-distutils' has no installation candidatewhich can be seen in this build log from PR googleapis/python-pubsub#1220.This PR also updates the default python version to be 3.10 for the
docssession to match what we use fordocfx.synthtool/synthtool/gcp/templates/python_library/noxfile.py.j2
Lines 358 to 359 in 0142f35
synthtool/synthtool/gcp/templates/python_library/noxfile.py.j2
Lines 393 to 394 in 0142f35
I tested that this build successfully by running
docker build -t test_docs .in the directorysynthtool/gcp/templates/python_library/.kokoro/docker/docs/I then ran the following nox sessions
docsanddocfx.Note: The both the
docsanddocfxsession now require Python 3.10.Then in the docker image, run the following commands