Add ability to format java code with a custom google-java-format version#145
Merged
Merged
Conversation
theacodes
reviewed
Nov 20, 2018
theacodes
reviewed
Nov 20, 2018
theacodes
reviewed
Nov 20, 2018
theacodes
reviewed
Nov 20, 2018
theacodes
approved these changes
Nov 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage would be something like:
Note the gapic-generator does run version 1.1 of the Google java formatter and this one defaults to 1.6 (most up to date). We can update the one in gapic, but we'd also like the ability to run this on our apiary libraries too.