Skip to content

chore: increase AssertByPollingTest timeout#1641

Merged
burkedavison merged 1 commit intomainfrom
assertbypolling-increase-test-timeout
Apr 20, 2023
Merged

chore: increase AssertByPollingTest timeout#1641
burkedavison merged 1 commit intomainfrom
assertbypolling-increase-test-timeout

Conversation

@burkedavison
Copy link
Member

This test failed due to a timeout: https://github.com/googleapis/gapic-generator-java/actions/runs/4749547068/jobs/8436916413

This happens if the OS takes significantly longer to return to the thread than the requested sleep time.

This PR increases the timeout from 100ms to 300ms.

@burkedavison burkedavison requested a review from a team April 20, 2023 13:18
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 20, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@burkedavison burkedavison merged commit 7203192 into main Apr 20, 2023
@burkedavison burkedavison deleted the assertbypolling-increase-test-timeout branch April 20, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants