Skip to content

chore: Close gRPC Identity client#1628

Merged
lqiu96 merged 1 commit intomainfrom
main-close_grpc_client
Apr 14, 2023
Merged

chore: Close gRPC Identity client#1628
lqiu96 merged 1 commit intomainfrom
main-close_grpc_client

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Apr 14, 2023

Seeing this error in the CIs:

Apr 14, 2023 4:21:13 PM io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference cleanQueue
SEVERE: *~*~*~ Previous channel ManagedChannelImpl{logId=23, target=localhost:7469} was not shutdown properly!!! ~*~*~*
    Make sure to call shutdown()/shutdownNow() and wait until awaitTermination() returns true.
java.lang.RuntimeException: ManagedChannel allocation site

Forgot to close the gRPC client.

@lqiu96 lqiu96 requested review from a team, blakeli0, burkedavison and mpeddada1 April 14, 2023 16:31
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 14, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lqiu96 lqiu96 merged commit ca4de24 into main Apr 14, 2023
@lqiu96 lqiu96 deleted the main-close_grpc_client branch April 14, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants