Skip to content

chore: migrate showcase tests job for graalvm from GA to kokoro #1625

Merged
mpeddada1 merged 10 commits intomainfrom
migrate-showcase-job-to-kokoro
Apr 21, 2023
Merged

chore: migrate showcase tests job for graalvm from GA to kokoro #1625
mpeddada1 merged 10 commits intomainfrom
migrate-showcase-job-to-kokoro

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Apr 13, 2023 •
edited
Loading

Migrating the showcase GraalVM check from Github Actions to Kokoro where the downstream tests are set up for ease of maintenance.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 13, 2023
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Apr 17, 2023
@mpeddada1 mpeddada1 marked this pull request as ready for review April 17, 2023 16:54
@mpeddada1 mpeddada1 requested a review from a team April 17, 2023 16:54
@mpeddada1 mpeddada1 changed the title chore: migrate showcase tests job for graalvm from GA to kokoro [Do not merge] chore: migrate showcase tests job for graalvm from GA to kokoro Apr 17, 2023
blakeli0
blakeli0 reviewed Apr 17, 2023
View reviewed changes
.kokoro/presubmit/downstream-build.sh

set -eo pipefail

SHOWCASE_VERSION=0.26.1
Copy link
Contributor

@blakeli0 blakeli0 Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to update renovate.json to update this version automatically, since this is now in a shell script

Copy link
Contributor Author

@mpeddada1 mpeddada1 Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, adjusted the renovate bot config to point to the shell script.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 17, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 17, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 17, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mpeddada1 mpeddada1 merged commit c2d6d15 into main Apr 21, 2023
@mpeddada1 mpeddada1 deleted the migrate-showcase-job-to-kokoro branch April 21, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@burkedavison burkedavison burkedavison approved these changes

@suztomo suztomo Awaiting requested review from suztomo

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mpeddada1 @blakeli0 @burkedavison @kokoro-team