Skip to content

Conversation

@renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Feb 16, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.protobuf:protobuf-java (source) 3.21.10 -> 3.22.2 age adoption passing confidence
com.google.protobuf:protobuf-bom (source) 3.21.12 -> 3.22.2 age adoption passing confidence

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.


Release Notes

protocolbuffers/protobuf

v3.22.2

Compare Source

v3.22.1

Compare Source

v3.22.0

Compare Source

v3.21.12

Compare Source

v3.21.11

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team as a code owner February 16, 2023 20:36
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 16, 2023
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2023
@blakeli0 blakeli0 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 22, 2023
@blakeli0
Copy link
Contributor

As discussed with @suztomo, do not merge this until googleapis updates the protobuf compiler version to 3.22.

Copy link
Contributor

@diegomarquezp diegomarquezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until googleapis updates the protobuf compiler version to 3.22.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 27, 2023
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 27, 2023
@suztomo
Copy link
Member

suztomo commented Mar 8, 2023

Waiting for https://github.com/googleapis/googleapis/blob/master/WORKSPACE#L83 to have Protobuf 3.22.0 or higher.

@renovate-bot renovate-bot force-pushed the renovate/protobuf-dependencies branch from b24e0d0 to 402ed10 Compare March 8, 2023 21:16
@renovate-bot renovate-bot changed the title deps: update dependency com.google.protobuf:protobuf-bom to v3.22.0 deps: update protobuf dependencies to v3.22.1 Mar 8, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2023
@suztomo
Copy link
Member

suztomo commented Mar 8, 2023

@blakeli0 @meltsufin Now the two files (pom.xml and dependencies.properties) are managed by one pull request. Thank you for the pointer today.

Screenshot 2023-03-08 at 4 19 38 PM

But "ci-maven / build" started failing.

/home/runner/.cache/bazel/_bazel_runner/1f815583ebc8da6875b9074f31ba9a5d/external/bazel_tools/tools/build_defs/repo/http.bzl:353:31: in <toplevel>
(21:19:47) ERROR: /home/runner/work/gapic-generator-java/gapic-generator-java/BUILD.bazel:5:12: //:protoc-gen-java_gapic depends on @maven//:com_google_api_gapic_generator_java in repository @maven which failed to fetch. no such package '@maven//': Error while fetching artifact with coursier: OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
Resolution error: Error downloading $com.google.protobuf:protobuf-java:
  not found: /home/runner/.m2/repository/$com/google/protobuf/protobuf-java/protobuf-java-.pom
  not found: https://repo.maven.apache.org/maven2/$com/google/protobuf/protobuf-java//protobuf-java-.pom

The strange "$" mark seems related to this issue protocolbuffers/protobuf#12170

@renovate-bot renovate-bot changed the title deps: update protobuf dependencies to v3.22.1 deps: update protobuf dependencies to v3.22.2 Mar 10, 2023
@renovate-bot renovate-bot force-pushed the renovate/protobuf-dependencies branch from 402ed10 to 4a3f641 Compare March 10, 2023 19:24
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2023
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Comment on lines +6 to +7
build --cxxopt=-std=c++14
build --host_cxxopt=-std=c++14
Copy link
Member

@suztomo suztomo Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From protocolbuffers/protobuf#12393 to resolve "C++ versions less than C++14 are not supported."

@suztomo suztomo changed the title deps: update protobuf dependencies to v3.22.2 deps: update protobuf dependencies to v3.22.3 Apr 13, 2023
@emmileaf
Copy link
Contributor

As of the 4/25 release cycle, the protobuf version in googleapis is 3.21.12: https://github.com/googleapis/googleapis/blob/ab4ba823439f786b2091984fed6408a950aaef9e/WORKSPACE#L83

Keeping this as Do not merge.

@alicejli
Copy link
Contributor

alicejli commented May 8, 2023

As of the 5/8 release cycle, the protobuf version in googleapis is 3.21.12: https://github.com/googleapis/googleapis/blame/master/WORKSPACE#L162

Keeping this as Do not merge.

@alicejli alicejli added the automerge Merge the pull request once unit tests and other checks pass. label May 10, 2023
@alicejli alicejli self-requested a review May 10, 2023 17:00
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 10, 2023
@alicejli alicejli added the automerge Merge the pull request once unit tests and other checks pass. label May 11, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 12, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@suztomo
Copy link
Member

suztomo commented May 23, 2023

@mpeddada1 Can you bump the version to 3.23.1?

@mpeddada1
Copy link
Contributor

PR to bump version to 3.23.1 created at #1698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants