Skip to content

ci: setting up job to sync service_config.proto #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
suztomo wants to merge 1 commit into from
Closed

ci: setting up job to sync service_config.proto #1359

suztomo wants to merge 1 commit into from

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Feb 15, 2023

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@suztomo suztomo requested a review from a team as a code owner February 15, 2023 18:57
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 15, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@suztomo
Copy link
Member Author

suztomo commented Feb 15, 2023

Talked with Blake. Because the file is seldom updated, it's better to add a section in README.md.

Also this pull request relies on master branch, not a released version, which may contain temporary changes there.

@suztomo suztomo closed this Feb 15, 2023
@suztomo suztomo mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@suztomo