Skip to content

fix(spring): Separate out client settings bean and client bean comment #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhumin8 merged 2 commits into from
Jan 4, 2023
Merged

fix(spring): Separate out client settings bean and client bean comment #1209

zhumin8 merged 2 commits into from
Jan 4, 2023

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Jan 4, 2023

Addressing: #1110 (comment)
This was leftover from changes made in #1110

@zhumin8 zhumin8 added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Jan 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zhumin8 zhumin8 marked this pull request as ready for review January 4, 2023 17:32
@zhumin8 zhumin8 requested a review from a team as a code owner January 4, 2023 17:32
@zhumin8 zhumin8 merged commit 62153dc into autoconfig-gen-draft2 Jan 4, 2023
@zhumin8 zhumin8 deleted the separate-client-setting-bean-comment branch January 4, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meltsufin meltsufin meltsufin approved these changes

@diegomarquezp diegomarquezp Awaiting requested review from diegomarquezp

+1 more reviewer

@emmileaf emmileaf emmileaf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhumin8 @emmileaf @meltsufin