Skip to content

v2.0.0's unused resname class removal deletes useful classes #819

@aohren

Description

@aohren

The unused resname class removal in #814 causes the removal of ~4 *Name.java classes from googleads API. It's likely doing its job, as I think the resource names in question are indeed not referenced anywhere in a method_signature or a resource_reference.

However, googleads has a generic query search method for fetching data, and some of the resource name classes in question are valid filter predicates in our search query language. Thus, generating the *Name.java classes for them is still a useful developer surface that can assist our users in constructing queries that filter on resource name values, even if they're not formally used elsewhere in the GAPIC surface.

Can we either revert this or at least supply a flag value we can set in our Bazel java targets to turn off this behavior?

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions