-
Notifications
You must be signed in to change notification settings - Fork 69
Closed
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.Issues that are directly related to samples.
Description
This seems to be happening only in a very limited scope of the paginated <smth>Callable() methods.
The incode-samples for paginated methods seem missing request creation logic. This is how they look now
// AUTO-GENERATED DOCUMENTATION AND METHOD.
/**
* Lists DeidentifyTemplates. See https://cloud.google.com/dlp/docs/creating-templates-deid to
* learn more.
*
* <p>Sample code:
*
* <pre>{@code
* try (DlpServiceClient dlpServiceClient = DlpServiceClient.create()) {
* while (true) {
* ListDeidentifyTemplatesResponse response =
* dlpServiceClient.listDeidentifyTemplatesCallable().call(request);
* for (DeidentifyTemplate element : response.getResponsesList()) {
* // doThingsWith(element);
* }
* String nextPageToken = response.getNextPageToken();
* if (!Strings.isNullOrEmpty(nextPageToken)) {
* request = request.toBuilder().setPageToken(nextPageToken).build();
* } else {
* break;
* }
* }
* }
* }</pre>
*/
public final UnaryCallable<ListDeidentifyTemplatesRequest, ListDeidentifyTemplatesResponse>
listDeidentifyTemplatesCallable() {
return stub.listDeidentifyTemplatesCallable();
}Notice that the request is not defined when first used in the example above.
Also there is an extra } right at the end (before </pre> element).
This is how they used to be:
// AUTO-GENERATED DOCUMENTATION AND METHOD
/**
* Lists DeidentifyTemplates. See https://cloud.google.com/dlp/docs/creating-templates-deid to
* learn more.
*
* <p>Sample code:
*
* <pre><code>
* try (DlpServiceClient dlpServiceClient = DlpServiceClient.create()) {
* OrganizationLocationName parent = OrganizationLocationName.of("[ORGANIZATION]", "[LOCATION]");
* ListDeidentifyTemplatesRequest request = ListDeidentifyTemplatesRequest.newBuilder()
* .setParent(parent.toString())
* .build();
* while (true) {
* ListDeidentifyTemplatesResponse response = dlpServiceClient.listDeidentifyTemplatesCallable().call(request);
* for (DeidentifyTemplate element : response.getDeidentifyTemplatesList()) {
* // doThingsWith(element);
* }
* String nextPageToken = response.getNextPageToken();
* if (!Strings.isNullOrEmpty(nextPageToken)) {
* request = request.toBuilder().setPageToken(nextPageToken).build();
* } else {
* break;
* }
* }
* }
* </code></pre>
*/
public final UnaryCallable<ListDeidentifyTemplatesRequest, ListDeidentifyTemplatesResponse>
listDeidentifyTemplatesCallable() {
return stub.listDeidentifyTemplatesCallable();
}The request is defined and initialized before being used.
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.Issues that are directly related to samples.