docs: Update docs for GoogleCredentialsProvider#setScopesToApply #4057
Conversation
Summary of ChangesHello @blakeli0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the clarity of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Javadoc for GoogleCredentialsProvider#setScopesToApply to clarify that scopes are only applied when the underlying credentials require them. This change accurately reflects the implementation and improves the documentation by adding a link to GoogleCredentials#createScopedRequired() for further context. The change is correct and well-implemented. I have no further suggestions.
|
|
🤖 I have created a release *beep* *boop* --- <details><summary>2.65.1</summary> ## [2.65.1](v2.65.0...v2.65.1) (2026-01-13) ### Documentation * Update docs for GoogleCredentialsProvider#setScopesToApply ([#4057](#4057)) ([0a9962f](0a9962f)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Diego Marquez <diegomarquezp@google.com>
GoogleCredentialsProvider#setScopesToApply would only work if the underlying credentials require the scopes to be set. Update the docs to reflect the intended behavior.
Fixes #3738