feat: new artifact for sdk-platform-java configs. #2315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
burkedavison
left a comment
There was a problem hiding this comment.
LGTM, let's get Tomo's approval as well since this is creating a new artifact.
burkedavison
approved these changes
Jan 2, 2024
Contributor
Author
|
@suztomo Could we get your final sign off on this PR? |
suztomo
approved these changes
Jan 3, 2024
burkedavison
approved these changes
Jan 3, 2024
suztomo
approved these changes
Jan 3, 2024
Member
|
10 mins after merging this, ensure the Release Please pull request #2290 updates appropriate lines. |
Contributor
Author
|
Will do! Thanks |
|
|
suztomo
reviewed
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This artifact is meant to mirror java-shared-config with the java-shared-dependencies version to then be consumed by downstream libraries (including the monorepo and handwritten libraries). The purpose of this artifact is to have a single update PR in the downstream libs to update shared-config and shared-dependencies instead of two.
Name of the artifact:
sdk-platform-java-config