Skip to content

fix: use && in equals check to avoid possible NPE #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
burkedavison merged 2 commits into from
Aug 17, 2023
Merged

fix: use && in equals check to avoid possible NPE #1927

burkedavison merged 2 commits into from
Aug 17, 2023

Conversation

@burkedavison
Copy link
Member

@burkedavison burkedavison commented Aug 17, 2023 •
edited
Loading

Fixes #1928

@burkedavison burkedavison requested a review from a team as a code owner August 17, 2023 17:49
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 17, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 17, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

23.1% 23.1% Coverage
42.9% 42.9% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 17, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
60.0% 60.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 17, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
60.0% 60.0% Duplication

@burkedavison burkedavison merged commit 815567c into main Aug 17, 2023
@burkedavison burkedavison deleted the fix-equals-or-to-and branch August 17, 2023 18:30
@release-please release-please bot mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PubSub Awkward implementation of SubscriptionName::equals

2 participants

@burkedavison @blakeli0