-
Notifications
You must be signed in to change notification settings - Fork 69
Closed
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
We should not generate REST methods if the RPC does not have HTTP annotation. See this proto and the proto that has it.
In this case, we are already not generating REST methods because it's BIDI streaming, but we need to use the HTTP annotation as the filter instead of using RPC type.
In addition, we should not generating the client at all if there are no RPCs with HTTP annotation. See go/actools-diregapic-parallelization-sync for details.
There could be multiple reasons an RPC does not have HTTP annotation:
- The RPC is not supposed to be supported by REST. e.g. BIDI streaming methods
- The RPC is not yet supported by the backend service, but could be supported in the future
- The proto is not properly configured.
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.